#15467 closed defect (fixed)
Partitions return wrong result for obvious reasons
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.1 |
Component: | combinatorics | Keywords: | |
Cc: | sage-combinat | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Andrew Mathas |
Report Upstream: | N/A | Work issues: | |
Branch: | u/ncohen/15467 (Commits, GitHub, GitLab) | Commit: | 5993eac06a1654326b0f992b6f4a73b67c362f6f |
Dependencies: | Stopgaps: |
Description (last modified by )
As reported there : https://groups.google.com/d/topic/sage-combinat-devel/vyMs7PQ8KbA/discussion
This patch makes the constructor of Partitions scream instead of returning garbage.
Change History (9)
comment:1 Changed 8 years ago by
- Branch set to u/ncohen/15467
- Cc sage-combinat added
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Commit set to 5993eac06a1654326b0f992b6f4a73b67c362f6f
comment:3 Changed 8 years ago by
- Milestone changed from sage-5.13 to sage-6.0
- Reviewers set to Andrew Mathas
- Status changed from needs_review to positive_review
Doesn't break anything and fixes some bugs, so positive review.
I've bumped the version number to 6 since the commits come from git.
comment:4 Changed 8 years ago by
Wow, cool ! Thank you very much for reviewing that :-)
Nathann
comment:5 Changed 8 years ago by
- Milestone changed from sage-6.0 to sage-6.1
comment:6 Changed 8 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
comment:7 follow-up: ↓ 8 Changed 7 years ago by
Just out of curiosity, would it be okay for me to add an enhancement ticket asking that we could eventually add the ability to combine (say) parts_in
with other options? That would have been useful for me in a class tomorrow, but maybe there is no need. Or maybe such a ticket already exists!
comment:8 in reply to: ↑ 7 Changed 7 years ago by
Just out of curiosity, would it be okay for me to add an enhancement ticket asking that we could eventually add the ability to combine (say)
parts_in
with other options? That would have been useful for me in a class tomorrow, but maybe there is no need. Or maybe such a ticket already exists!
I do not know if such a ticket exists. I do not believe that it takes more than a couple of hours to write this feature (in Python), however.
Nathann
comment:9 Changed 7 years ago by
Ok, I've opened #17081.
Branch pushed to git repo; I updated commit sha1. New commits: